Fix (delegated) targets metadata HASHES definition #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove not fully accurate phrase in the HASHES definition in
section “4.5. File formats: targets.json and delegated target
roles” of the spec.
Contrary to that phrase, HASHES is an unconditionally mandatory
value under each TARGETPATH for top-level targets and all delegated
targets:
{ TARGETPATH : {
"length" : LENGTH,
"hashes" : HASHES,
("custom" : { ... }) }
, ...
}
lukpueh
force-pushed
the
fix-targets-HASHES
branch
from
40bf6b1
to
735e2be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove not fully accurate phrase in the
HASHESdefinition in section “4.5. File formats: targets.json and delegated target roles” of the spec.Contrary to that phrase,
HASHESis an unconditionally mandatory value under eachTARGETPATHfor top-level targets and all delegated targets roles:It seems like this accidentally slipped through our review in the recent (and actually unrelated) #47. (cc @erickt, @trishankatdatadog).