Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should be asked to enter their full name in register step #17

Open
1 task
thevahidal opened this issue Nov 25, 2022 · 12 comments
Open
1 task

User should be asked to enter their full name in register step #17

thevahidal opened this issue Nov 25, 2022 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@thevahidal
Copy link
Owner

thevahidal commented Nov 25, 2022

Users should complete their profile (full_name) in order to be able to write stories and story parts. We need to ask for their full name when they're signing up to prevent extra steps in the future.

Criteria

  • In the register screen we should ask for three mandatory fields:
    • full name
    • email address (already exists)
    • password (already exists)

Reproducing Steps

  1. Anonymous user tries to create a story [story part].
  2. Novel will show an error that they need to be authenticated and redirect them to the login screen.
  3. User register with their email address and password and after verifying their email address they get redirected to Novel.
  4. They try to create a story [story part] again. They write their story [story part] and hit Enter to submit it.
  5. Novel will show another error, saying that they need to complete their profile, and redirect them to the Profile screen.
  6. User's story is gone as they got redirected without their story [story part] being saved.
@mnosov622
Copy link
Contributor

Hi @thevahidal !

I would love to work on that. Could you assign it to me, please ?

@thevahidal
Copy link
Owner Author

Hi @mnosov622,
Thanks for coming forward to collaborate on Novel. I'd love to see you working on this task, too.
You can start I'll assign it to you, but I have to provide some information for you to run the project locally as right now we don't have anything on how to do it.
Also, I'll add some contribution guidelines and a code of conduct so everyone can follow the same rules.

Thanks again, and I assigned this to you. Good luck and can't wait to see your PR.

@mnosov622
Copy link
Contributor

Hi @thevahidal !

Thank you so much !

@mnosov622
Copy link
Contributor

For now, my suggestion is to have down-vote and up-vote icons in the bottom right corner
image

As well as in the top of the story. What do you think ?

image

@mnosov622
Copy link
Contributor

@thevahidal and could you tell me who do I run this project locally, please ?

image

@thevahidal
Copy link
Owner Author

@thevahidal and could you tell me who do I run this project locally, please ?

image

I'm creating a development guide and will finish it asap. You can follow it in this issue #35 .

@mnosov622
Copy link
Contributor

mnosov622 commented Nov 26, 2022 via email

@mnosov622
Copy link
Contributor

Hi @thevahidal !

Do you mind exchanging with discord or something like that, so we can talk more about the project ?

I would love to work with you on your project :) I like the idea.

@thevahidal
Copy link
Owner Author

Hey @mnosov622,
Please send me your email address so I can give you my contact info.

@mnosov622
Copy link
Contributor

mnosov622 commented Nov 28, 2022 via email

@thevahidal
Copy link
Owner Author

@mnosov622,
It doesn't show your email address, it's like this @.***

@mnosov622
Copy link
Contributor

Oh, really.

Let's do it that way. My email is my login: mnosov622 + gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants