Adapt WCIF date parsing to escape from timezone hell #472
Conversation
|
Look at the generation date before
And now
Also, LocalDate are cleaner to our case, since we just need yyyy-mm-dd, which is precisely what LocalDate is. At least for AdelaideSummer your fix worked! I'm finishing the tests later though. Spending 5h to setup kotlin was not funny (issue with the kotlin eclipse plugin that made me download IntelliJ IDEA community; it's quite impressive how we can forget how to code by just switching IDEs). |
gregorbg
force-pushed
the
fixup/wcif-timezones
branch
from
b354621
to
7e091fe
Compare
|
Oh boy. Thanks for your patience! What a bummer to hear that you struggled to set up Kotlin 😞 I have a good connection to some JetBrains guys, maybe I can convince them to give some more love to the Eclipse plugin. Anyways, I've reverted back to LocalDate because your argument absolutely makes sense. The timestamp in the top-left corner is a completely unrelated issue, please disregard for this PR. |
|
FYI: PDF watermarking is fixed in #473 |
|
I believe I'll start using kotlin on the native Idellij. Also, as a professor, I have access to the educational version (I use Eclipse just because I think I like it more). Anyways, I filled an issue there :) Your code passed all scenarios I tested! |
|
Thank you for the review! (And for the attention of noticing this error in the first place) |
Potentially fixes #471