Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pruning folder code to separate feature branch #476

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

gregorbg
Copy link
Member

@gregorbg gregorbg commented Jan 8, 2020

Right now, we create an empty folder that is unused, because pruning is only (subject to being) added in #461

Until the .15 releases, this folder used to be necessary for resources. But now, we can access these directly from within the JAR so we should not create an empty folder.

Merging as soon as Travis says Yes because this is only moving "dead code" to another branch that will then be reviewed again more thoroughly.

@gregorbg
Copy link
Member Author

gregorbg commented Jan 8, 2020

Retry after merging #477

@gregorbg gregorbg closed this Jan 8, 2020
@gregorbg gregorbg reopened this Jan 8, 2020
@gregorbg
Copy link
Member Author

gregorbg commented Jan 8, 2020

Okay, only reasonable fix seems to be brute force retry for now :/

@gregorbg gregorbg closed this Jan 8, 2020
@gregorbg gregorbg reopened this Jan 8, 2020
@gregorbg gregorbg merged commit f337e25 into thewca:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant