Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsing side bar #638

Merged
merged 4 commits into from
Dec 24, 2020
Merged

Collapsing side bar #638

merged 4 commits into from
Dec 24, 2020

Conversation

JonEsparaz
Copy link
Contributor

@JonEsparaz JonEsparaz commented Dec 24, 2020

Resolves #623.

When screen width is less than 992px, the side bar collapses and is placed at the top of the screen:

Clicking the toggle button reveals the log in, competition and manual selection buttons:

First time contributing in this repo - please let me know if there's any suggestions :)

@campos20
Copy link
Member

Great! Great thing you sent that because I'm about to touch every file. Some observations

tnoodle-ui/src/main/components/SideBar.jsx Outdated Show resolved Hide resolved
tnoodle-ui/src/test/SideBar.test.js Outdated Show resolved Hide resolved
@JonEsparaz
Copy link
Contributor Author

@campos20 changes are done. Please let me know if there's anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse side bar
2 participants