Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WPA/BPA display for final rounds #179

Merged
merged 8 commits into from
Aug 21, 2023

Conversation

maxidragon
Copy link
Contributor

Closes #174

Now final round looks like this:

image

Projector view:

image

I'm not sure how sorting should be resolved, I think it's not bad like this, but I'm open to suggestions on how it could be done better.

@jonatanklosko
Copy link
Member

jonatanklosko commented Aug 18, 2023

Hey, thanks for the PR! A few high level notes:

  1. I think green/red calls too much attention. Instead, let's use regular color but with opacity (such that it's clearly visible, but feels like a secondary detail).
  2. For rounds with mo3 we can show the current mean after 2 solves. Particularly useful for FMC.
  3. I don't think we need the toggle for now. With the opacity it should be subtle enough. If it turns out confusing to people, we can have a settings icon with more control.
  4. It would be nice to show a tooltip on each of these extra numbers with brief explanation of what the number is.

@maxidragon
Copy link
Contributor Author

maxidragon commented Aug 18, 2023

I made changes ;)

Now it looks like this:
image
image
image
image
image

@dunkOnIT
Copy link
Collaborator

Thanks, this looks awesome! One small nit - it looks like WPA / BPA are off-centre in your second-last screenshot - could we investigate the reason for this?

@maxidragon
Copy link
Contributor Author

@dunkOnIT fixed ;)

image

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! A couple comments with respect to code :)

client/src/components/RoundResults/RoundResultsTable.jsx Outdated Show resolved Hide resolved
client/src/components/RoundResults/RoundResultsTable.jsx Outdated Show resolved Hide resolved
client/src/components/RoundResults/RoundResultsTable.jsx Outdated Show resolved Hide resolved
client/src/lib/attempt-result.js Outdated Show resolved Hide resolved
client/src/lib/attempt-result.js Outdated Show resolved Hide resolved
client/src/components/RoundResults/RoundResultsTable.jsx Outdated Show resolved Hide resolved
client/src/lib/attempt-result.js Outdated Show resolved Hide resolved
client/src/components/Result/Result.jsx Outdated Show resolved Hide resolved
client/src/components/Result/Result.jsx Outdated Show resolved Hide resolved
Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks :)

@jonatanklosko jonatanklosko merged commit 31ca40f into thewca:main Aug 21, 2023
2 checks passed
@maxidragon maxidragon deleted the live-statistics branch August 21, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add live statistics (only for finals rounds?)
3 participants