Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated doc and fix some missing react-native permssions/files #3

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Updated doc and fix some missing react-native permssions/files #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a01323
Update installation notes
prestancedesign Sep 20, 2019
f74e1b4
Adding executable permissions to gradlew script
prestancedesign Sep 20, 2019
7b7729b
Readd missing default debug keystore due to gitignore
prestancedesign Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
```
$ npm install
$ npm install && cd react-native && npm install
$ shadow-cljs watch app

;; wait for first compile to finish or metro gets confused
Expand All @@ -23,4 +23,4 @@ The `:app` build will create an `react-native/app/index.js`. In `release` mode t

`:init-fn` is called after all files are loaded and in the case of `expo` must render something synchronously as it will otherwise complain about a missing root component.

`reagent.core` loads `reagent.dom` which will load `react-dom` which we don't have or need. Including the `src/main/reagent/dom.cljs` to create an empty shell. Copied from [re-natal](https://github.com/drapanjanas/re-natal/blob/master/resources/cljs-reagent6/reagent_dom.cljs).
`reagent.core` loads `reagent.dom` which will load `react-dom` which we don't have or need. Including the `src/main/reagent/dom.cljs` to create an empty shell. Copied from [re-natal](https://github.com/drapanjanas/re-natal/blob/master/resources/cljs-reagent6/reagent_dom.cljs).
1 change: 1 addition & 0 deletions react-native/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ yarn-error.log
buck-out/
\.buckd/
*.keystore
!debug.keystore

# fastlane
#
Expand Down
Binary file added react-native/android/app/debug.keystore
View file
Open in desktop
Binary file not shown.
Empty file modified react-native/android/gradlew
100644 → 100755
View file
Open in desktop
Empty file.