Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing tests for c8y-log-manager and fixing a bug that causes mqtt actor termination #2161

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

Ruadhri17
Copy link
Contributor

Proposed changes

This PR consists of two parts:

  1. Adding missing Robot framework tests for c8y-log-plugin.
  2. Fixing bug in log manager: It returns error message instead of Ok(()) which cause mqtt actor termination

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the fix preventing the log-manager to abort on errors is correct.

@Ruadhri17 Ruadhri17 temporarily deployed to Test Pull Request August 17, 2023 08:54 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2161 (8b8961e) into main (4ea00b6) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Additional details and impacted files
Files Changed Coverage Δ
crates/extensions/c8y_log_manager/src/actor.rs 80.6% <0.0%> (-0.2%) ⬇️

... and 2 files with indirect coverage changes

@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
253 0 5 253 100

Copy link
Contributor

@gligorisaev gligorisaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and it looks ok

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@didier-wenzek didier-wenzek merged commit d35823f into thin-edge:main Aug 21, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants