Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing steps for configuration list #2465

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

gligorisaev
Copy link
Contributor

Add testing steps to check the configuration of:

  • c8y.proxy.bind.address
  • c8y.proxy.bind.port
  • c8y.proxy.client.host
  • c8y.proxy.client.port
  • c8y.bridge.include.local_cleansession
  • mqtt.topic_root
  • mqtt.device_topic_id
  • mqtt.client.host
  • mqtt.client.port
  • http.bind.address
  • http.client.port
  • http.client.host
  • software.plugin.max_packages
  • run.lock_files

-->

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
376 0 3 376 100 55m30.140999999s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@gligorisaev gligorisaev merged commit 3142e33 into thin-edge:main Nov 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants