Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct note about certificate chain order #2607

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Fix documentation about the order of certificates in the cert chain (when using a signing cert). The first cert in the chain must be the device cert.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added the documentation Improvements or additions to documentation label Jan 21, 2024
Copy link
Contributor

github-actions bot commented Jan 21, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
381 0 3 381 100 58m40.294s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Indeed, the order was incorrect.

@reubenmiller reubenmiller added this pull request to the merge queue Jan 22, 2024
@reubenmiller
Copy link
Contributor Author

Approved. Indeed, the order was incorrect.

Yes that was my fault, so it was fitting that I fixed it.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 22, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Jan 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 23, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Jan 24, 2024
Merged via the queue into thin-edge:main with commit a53611a Jan 24, 2024
18 checks passed
@reubenmiller reubenmiller deleted the docs-cert-chain-order branch July 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants