Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the PySys tests #2655

Merged

Conversation

didier-wenzek
Copy link
Contributor

Proposed changes

Simply remove all the PySys tests which have not been launched since more than one year.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Didier Wenzek <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
386 0 3 386 100 49m34.109s

@reubenmiller
Copy link
Contributor

@didier-wenzek There were some test cases defined in the PySys tests which we didn't have explicit 1:1 mapping to RobotFramework...though I guess we could argue that we've been fine for the last year without them.

@didier-wenzek
Copy link
Contributor Author

though I guess we could argue that we've been fine for the last year without them.

That's my point ;-)

There were some test cases defined in the PySys tests which we didn't have explicit 1:1 mapping to RobotFramework.

There are still accessible, arguably in a less convenient manner.

Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, let’s get rid of them.

@didier-wenzek didier-wenzek added this pull request to the merge queue Feb 1, 2024
Merged via the queue into thin-edge:main with commit 4011e66 Feb 1, 2024
18 checks passed
@didier-wenzek didier-wenzek deleted the test/remove-pysys-tests branch February 7, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants