Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apt): disable debian frontend when running apt commands #2672

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Disable debian frontends whilst running apt commands in tedge-apt-plugin

This avoids packages failing due to interactive frontend.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2671

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a1c8bda) 75.9% compared to head (ca154f9) 76.0%.
Report is 1 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
plugins/tedge_apt_plugin/src/lib.rs 25.6% <0.0%> (-0.2%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 4, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
390 0 3 390 100 52m25.716s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Feb 5, 2024
@reubenmiller reubenmiller added the theme:software Theme: Software management label Feb 5, 2024
Merged via the queue into thin-edge:main with commit e55ecbd Feb 5, 2024
20 checks passed
@reubenmiller reubenmiller deleted the fix-disable-debian-frontends branch July 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:software Theme: Software management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants