Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use more robust http parsing in the c8y-proxy host header tests #2956

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jarhodes314
Copy link
Contributor

Proposed changes

Improve the host header tests introduced in #2946 by actually parsing the headers instead of simply checking for the presence of a string in the incoming request. Additionally simplify the logic for obtaining the websocket host.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.3%. Comparing base (e54f81a) to head (d1359b0).
Report is 1 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
crates/extensions/c8y_auth_proxy/src/server.rs 89.8% <93.3%> (+1.0%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
453 0 3 453 100 58m36.590424999s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jarhodes314 jarhodes314 added this pull request to the merge queue Jun 21, 2024
Merged via the queue into thin-edge:main with commit f35f1f1 Jun 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:c8y Theme: Cumulocity related topics theme:testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants