Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: changelog generation from tags and don't fail on errors #3044

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

A problem with the changelog from/to version detection prevented the release pipeline from completing. As a result the following changes are proposed:

  • Option to detect the changelog from/to (e.g. previous release and current release) from git tags.
  • Don't fail the pipeline if the changelog generation fails (as this is not strictly required for a release and can be run locally). This logic could be removed in the future once the changelog generation has been verified in production

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added the ci/cd Repository management and pipeline topics label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.0%. Comparing base (b79f03a) to head (2f26431).
Report is 5 commits behind head on main.

Additional details and impacted files

see 8 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
491 0 2 491 100 1h28m38.819343999s

@reubenmiller reubenmiller added this pull request to the merge queue Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Aug 1, 2024
Merged via the queue into thin-edge:main with commit 2e038b5 Aug 1, 2024
33 checks passed
@reubenmiller reubenmiller deleted the ci-changelog-generate-from-tags branch August 1, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants