refactor: CommandStatus::Executing takes extra MQTT messages #3049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Unlike other c8y operations that we support so far,
c8y_DeviceProfile
operation requires a inventory update MQTT message afterEXECUTING
message. Refer to the doc.This PR changes
CommandStatus::Executing
to take extra MQTT messages after sendingEXECUTING
message to c8y.P.S.
If we have a requirement that extra messages need to be send right before the
EXECUTING
message, this API need to be changed again. It will probably look likeCommandStatus::Executing {messages: Vec<MqttMessage>}
and all operation handlers need to add501,<op_type
message to the vector explicitly. Since there is no such a requirement as of now, I prefer to hide501
message creation inside the API as it is.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments