Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use explicit user/group id in container image #3118

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Use explicit user/group ids in the docker image to enable more predicatable behaviour across different build systems and images.

References

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller force-pushed the feat-docker-container-user-config branch from 2ba7705 to 8e3a5c3 Compare September 9, 2024 09:33
@reubenmiller reubenmiller added theme:packaging Theme: Packaging and release artefact topics theme:containers Theme: Containerisation topics labels Sep 9, 2024
Copy link
Contributor

@Ruadhri17 Ruadhri17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with docker instructions and addgroup/adduser instructions for Alpine. LGTM

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
504 0 2 504 100 1h29m3.729053s

@reubenmiller reubenmiller added this pull request to the merge queue Sep 9, 2024
Merged via the queue into thin-edge:main with commit e4ff79b Sep 9, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:containers Theme: Containerisation topics theme:packaging Theme: Packaging and release artefact topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants