Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support nodejs v12 #15

Closed
heartyoh opened this issue Nov 15, 2019 · 5 comments
Closed

support nodejs v12 #15

heartyoh opened this issue Nov 15, 2019 · 5 comments
Assignees
@lotstar87
Labels
enhancement New feature or request
Milestone
1.0-beta

Comments

@heartyoh
Copy link
Contributor

npm printer => npm node-native-printer 변경 검토.
@heartyoh heartyoh added the enhancement New feature or request label Nov 15, 2019
@heartyoh heartyoh added this to the 1.0-beta milestone Nov 15, 2019
@heartyoh heartyoh assigned lotstar87 and ghost Nov 15, 2019
@ghost
Copy link

ghost commented Nov 15, 2019 •
edited by ghost
Loading

node-native-printer도 같은 문제가 있으며, 문제 부분을 수정하고 다른 패키지로 묶어 재배포 필요

MatteoMeil/node-native-printer#25

@ghost
Copy link

ghost commented Nov 20, 2019

tojocky/node-printer#261

wait for the merge or edit package.json to code below.

{
  "dependencies": {
    "printer": "thiagoelg/node-printer#master"
  }
}

ghost pushed a commit to things-factory/print-proxy-service that referenced this issue Dec 11, 2019
Update package.json
8b22d5e 
things-factory/shell#15
ghost pushed a commit to things-factory/print-service that referenced this issue Dec 11, 2019
Update package.json
affccaa 
things-factory/shell#15
ghost pushed a commit to things-factory/board-service that referenced this issue Dec 11, 2019
Update package.json
1b50b3e 
things-factory/shell#15
@ghost
Copy link

ghost commented Dec 11, 2019

yarn install 실행 시에 printer 소스를 현재 노드 버전으로 자동으로 빌드해주지 않는 듯 함
수동으로 빌드해주거나 13버전을 사용해야 동작

@ghost
Copy link

ghost commented Dec 23, 2019

https://github.com/things-factory/node-printer

ghost pushed a commit to things-factory/print-service that referenced this issue Dec 23, 2019
support nodejs v12
3475e6c 
things-factory/shell#15
ghost pushed a commit to things-factory/board-service that referenced this issue Dec 23, 2019
support nodejs v12
65bf21d 
things-factory/shell#15
@ghost
Copy link

ghost commented Dec 23, 2019

프린터 출력을 위해 사용하는 모듈이 printer에서 @things-factory/node-printer로 변경되었습니다.
노드 버전 변경 후에는 작업할 프로젝트에서 yarn upgrade 실행 후 작업해야합니다.

이 이슈는 printer 모듈만 참조합니다.

@ghost ghost closed this as completed Dec 23, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lotstar87 lotstar87

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0-beta
Development

No branches or pull requests
2 participants
@heartyoh @lotstar87