Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess Typed Data JSON w/ >uint32 fields #100

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Nov 15, 2024

PR-Codex overview

This PR introduces a method to preprocess typed data JSON, specifically to stringify large integers. It updates the EcosystemWallet to use this method and adds tests to ensure the functionality works correctly.

Detailed summary

  • Added PreprocessTypedDataJson method in Utils to stringify large integers in JSON.
  • Updated EcosystemWallet to use processedJson instead of raw json when creating the request content.
  • Added unit tests for PreprocessTypedDataJson covering various scenarios, including large numbers and nested structures.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.15%. Comparing base (1fef151) to head (fe9a000).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Thirdweb/Thirdweb.Utils/Utils.cs 91.89% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   77.92%   78.15%   +0.23%     
==========================================
  Files          28       28              
  Lines        4375     4412      +37     
  Branches      611      618       +7     
==========================================
+ Hits         3409     3448      +39     
  Misses        800      800              
+ Partials      166      164       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit c9d7eec into main Nov 15, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/preprocess-json branch November 15, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants