Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration - BouncyCastle Fallback #92

Closed
wants to merge 2 commits into from

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Nov 6, 2024

PR-Codex overview

This PR enhances the SignOutAsync method in the EmbeddedWallet.Misc.cs file by adding a fallback encryption mechanism using BouncyCastle when the initial AES encryption fails.

Detailed summary

  • Added using statements for BouncyCastle cryptography classes.
  • Implemented a fallback encryption method using BouncyCastle's AesEngine and PaddedBufferedBlockCipher.
  • Replaced the original exception handling to include a new catch block for migration failure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.20%. Comparing base (65107c5) to head (c6a99a7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   78.17%   78.20%   +0.02%     
==========================================
  Files          28       28              
  Lines        4358     4358              
  Branches      610      610              
==========================================
+ Hits         3407     3408       +1     
  Misses        787      787              
+ Partials      164      163       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper
Copy link
Member Author

Too risky to use two algorithms here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants