Add deprecation warnings to dashboard folders #4878
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4878 +/- ##
=======================================
Coverage 47.60% 47.60%
=======================================
Files 1054 1054
Lines 57136 57136
Branches 3916 3916
=======================================
Hits 27197 27197
Misses 29251 29251
Partials 688 688
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
### TL;DR Added warning messages to deprecated folders in the dashboard to prevent further additions. ### What changed? Added `DO_NOT_ADD_THINGS_HERE.md` files to several deprecated folders within the dashboard's `src` directory. These folders include: - @3rdweb-sdk - classes - contract-ui - core-ui - og-lib - pages - tw-components Each file contains a warning message stating that the folder is deprecated and advising developers not to add new content to these locations. ### How to test? 1. Navigate to each of the mentioned folders in the dashboard's `src` directory. 2. Verify that the `DO_NOT_ADD_THINGS_HERE.md` file exists in each folder. 3. Open the files and confirm they contain the correct warning message. ### Why make this change? This change aims to prevent developers from adding new content to deprecated parts of the dashboard. By placing clear warning messages in these folders, we reduce the risk of introducing new code or features in areas that are scheduled for removal. This helps maintain code quality, reduces technical debt, and supports the ongoing efforts to modernize and streamline the dashboard's structure.
jnsdls
force-pushed
the
Add_deprecation_warnings_to_dashboard_folders
branch
from
cb94fc0
to
687a733
Compare
graphite-app
bot
deleted the
Add_deprecation_warnings_to_dashboard_folders
branch
TL;DR
Added warning messages to deprecated folders in the dashboard to prevent further additions.
What changed?
Added
DO_NOT_ADD_THINGS_HERE.mdfiles to several deprecated folders within the dashboard'ssrcdirectory. These folders include:Each file contains a warning message stating that the folder is deprecated and advising developers not to add new content to these locations.
How to test?
srcdirectory.DO_NOT_ADD_THINGS_HERE.mdfile exists in each folder.Why make this change?
This change aims to prevent developers from adding new content to deprecated parts of the dashboard. By placing clear warning messages in these folders, we reduce the risk of introducing new code or features in areas that are scheduled for removal. This helps maintain code quality, reduces technical debt, and supports the ongoing efforts to modernize and streamline the dashboard's structure.
PR-Codex overview
This PR adds a warning message across multiple
DO_NOT_ADD_THINGS_HERE.mdfiles in various directories of the dashboard, indicating that these parts are deprecated and discouraging the addition of new content.Detailed summary
apps/dashboard/src/pages/DO_NOT_ADD_THINGS_HERE.mdapps/dashboard/src/og-lib/DO_NOT_ADD_THINGS_HERE.mdapps/dashboard/src/classes/DO_NOT_ADD_THINGS_HERE.mdapps/dashboard/src/core-ui/DO_NOT_ADD_THINGS_HERE.mdapps/dashboard/src/@3rdweb-sdk/DO_NOT_ADD_THINGS_HERE.mdapps/dashboard/src/contract-ui/DO_NOT_ADD_THINGS_HERE.mdapps/dashboard/src/tw-components/DO_NOT_ADD_THINGS_HERE.mdsrcdirectory.