Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chain stack type check #4901

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Update chain stack type check #4901

merged 1 commit into from
Oct 3, 2024

Conversation

kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Oct 2, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces the stackType property across various files to enhance the handling of blockchain network configurations and improve the detection of ZkSync chains.

Detailed summary

  • Added stackType property to chains/types.ts and chains/utils.ts.
  • Included stackType in the embed-setup.tsx component.
  • Updated ConfigureNetworkForm.tsx to handle stackType.
  • Modified isZkSyncChain.ts to use getChainMetadata and check stackType for ZkSync chains.
  • Removed the getChainStack function, consolidating stack fetching logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: e91581a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 0:20am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 0:20am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 0:20am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 0:20am

Copy link

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.95 KB (0%) 840 ms (0%) 977 ms (-3.72% 🔽) 1.9 s
thirdweb (cjs) 101.63 KB (-0.08% 🔽) 2.1 s (-0.08% 🔽) 2.1 s (+4.67% 🔺) 4.1 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 65 ms (+55.01% 🔺) 161 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 150 ms (+265.79% 🔺) 160 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (+2.92% 🔺) 345 ms (+2.92% 🔺) 210 ms (+34.67% 🔺) 555 ms

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.57%. Comparing base (985c4b0) to head (e91581a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4901      +/-   ##
==========================================
+ Coverage   47.49%   47.57%   +0.07%     
==========================================
  Files        1055     1054       -1     
  Lines       57191    57142      -49     
  Branches     3902     3918      +16     
==========================================
+ Hits        27165    27185      +20     
+ Misses      29337    29268      -69     
  Partials      689      689              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 985c4b0
packages 43.31% <100.00%> (+0.08%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/chains/utils.ts 58.79% <100.00%> (+16.98%) ⬆️
...thirdweb/src/utils/any-evm/zksync/isZkSyncChain.ts 80.00% <100.00%> (-14.60%) ⬇️

... and 1 file with indirect coverage changes

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 2, 2024 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 2, 2024 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 2, 2024 23:50 Inactive
@kumaryash90 kumaryash90 added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 3, 2024
Copy link

graphite-app bot commented Oct 3, 2024

Merge activity

  • Oct 2, 8:06 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 2, 8:16 PM EDT: kumaryash90 added this pull request to the Graphite merge queue.
  • Oct 2, 8:21 PM EDT: kumaryash90 merged this pull request with the Graphite merge queue.

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new property `stackType` across various components and utilities, enhancing the handling of blockchain network configurations and metadata.

### Detailed summary
- Added `stackType` property in `types.ts` for chains.
- Updated `utils.ts` to include `stackType` from data.
- Included `stackType` in `embed-setup.tsx` and `ConfigureNetworkForm.tsx`.
- Modified the `isZkSyncChain` function to use `getChainMetadata` for `stackType` validation.
- Removed the obsolete `getChainStack` function.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants