-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chain stack type check #4901
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4901 +/- ##
==========================================
+ Coverage 47.49% 47.57% +0.07%
==========================================
Files 1055 1054 -1
Lines 57191 57142 -49
Branches 3902 3918 +16
==========================================
+ Hits 27165 27185 +20
+ Misses 29337 29268 -69
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more.
|
Merge activity
|
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces a new property `stackType` across various components and utilities, enhancing the handling of blockchain network configurations and metadata. ### Detailed summary - Added `stackType` property in `types.ts` for chains. - Updated `utils.ts` to include `stackType` from data. - Included `stackType` in `embed-setup.tsx` and `ConfigureNetworkForm.tsx`. - Modified the `isZkSyncChain` function to use `getChainMetadata` for `stackType` validation. - Removed the obsolete `getChainStack` function. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
86b6a0b
to
e91581a
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces the
stackType
property across various files to enhance the handling of blockchain network configurations and improve the detection of ZkSync chains.Detailed summary
stackType
property tochains/types.ts
andchains/utils.ts
.stackType
in theembed-setup.tsx
component.ConfigureNetworkForm.tsx
to handlestackType
.isZkSyncChain.ts
to usegetChainMetadata
and checkstackType
for ZkSync chains.getChainStack
function, consolidating stack fetching logic.