Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service-utils event publishing to accept any source #5162

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Oct 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the usageEventSchema in packages/service-utils/src/core/usage.ts by changing the type of the source field from an enumeration to a string, allowing for more flexibility in the values that can be assigned to source.

Detailed summary

  • Changed the type of source from z.enum([...]) to z.string().

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: 012f3de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 10:36pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 24, 2024 10:36pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 24, 2024 10:36pm
wallet-ui ⬜️ Skipped (Inspect) Oct 24, 2024 10:36pm

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.42%. Comparing base (8e43e34) to head (012f3de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5162   +/-   ##
=======================================
  Coverage   45.42%   45.42%           
=======================================
  Files        1065     1065           
  Lines       55145    55145           
  Branches     3970     3970           
=======================================
  Hits        25049    25049           
  Misses      29404    29404           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8e43e34
packages 40.44% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 2.3 s (-39.96% 🔽) 3.2 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 7 s (+16.52% 🔺) 9.1 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 201 ms (-25.65% 🔽) 298 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 246 ms (+504.82% 🔺) 256 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 510 ms (-62.73% 🔽) 857 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Oct 24, 2024
Copy link
Member Author

gregfromstl commented Oct 24, 2024

Merge activity

  • Oct 24, 6:24 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 24, 6:24 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 24, 6:36 PM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `usageEventSchema` in `packages/service-utils/src/core/usage.ts` by changing the type of the `source` field from an enumeration to a string, allowing for more flexibility in the values that can be assigned to `source`.

### Detailed summary
- Changed the `source` field in `usageEventSchema` from `z.enum` to `z.string()`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the fix/service-utils-event-parsing branch from d43f68d to 012f3de Compare October 24, 2024 22:25
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 24, 2024 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 24, 2024 22:25 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 24, 2024 22:25 Inactive
@graphite-app graphite-app bot merged commit 012f3de into main Oct 24, 2024
31 checks passed
@graphite-app graphite-app bot deleted the fix/service-utils-event-parsing branch October 24, 2024 22:36
@vercel vercel bot temporarily deployed to Production – wallet-ui October 24, 2024 22:36 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 24, 2024 22:36 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 24, 2024 22:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants