-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update service-utils event publishing to accept any source #5162
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5162 +/- ##
=======================================
Coverage 45.42% 45.42%
=======================================
Files 1065 1065
Lines 55145 55145
Branches 3970 3970
=======================================
Hits 25049 25049
Misses 29404 29404
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the `usageEventSchema` in `packages/service-utils/src/core/usage.ts` by changing the type of the `source` field from an enumeration to a string, allowing for more flexibility in the values that can be assigned to `source`. ### Detailed summary - Changed the `source` field in `usageEventSchema` from `z.enum` to `z.string()`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
d43f68d
to
012f3de
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR updates the
usageEventSchema
inpackages/service-utils/src/core/usage.ts
by changing the type of thesource
field from an enumeration to a string, allowing for more flexibility in the values that can be assigned tosource
.Detailed summary
source
fromz.enum([...])
toz.string()
.