-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle isContractDeployed error on contract page #5165
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5165 +/- ##
=======================================
Coverage 45.42% 45.42%
=======================================
Files 1065 1065
Lines 55145 55145
Branches 3970 3970
=======================================
Hits 25049 25049
Misses 29404 29404
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving error handling when checking if a contract is deployed. It ensures that if the contract check fails, it will not throw an error but instead return `false`. ### Detailed summary - Modified `isValidContract` assignment to handle errors gracefully by using `.catch(() => false)` instead of letting the promise reject. - Ensured that the flow continues to call `notFound()` if the contract is not valid. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
b707b1f
to
8e43e34
Compare
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR enhances error handling for contract validation in the
layout.tsx
file by ensuring that if the contract check fails, it defaults tofalse
instead of throwing an error.Detailed summary
isValidContract
assignment to handle errors gracefully by using.catch(() => false)
on theisContractDeployed(contract)
call.