Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular-ngrx-scss] issues tab #1941

Merged
merged 5 commits into from
Aug 29, 2023
Merged

[angular-ngrx-scss] issues tab #1941

merged 5 commits into from
Aug 29, 2023

Conversation

honzikec
Copy link
Contributor

Summary of change

Checklist

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for angular-ngrx-scss ready!

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/angular-ngrx-scss/deploys/64edff6fd145f10008575a74
😎 Deploy Preview https://deploy-preview-1941--angular-ngrx-scss.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for cra-rxjs-styled-components canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/cra-rxjs-styled-components/deploys/64edff6f632dd5000816cb6a

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for next-react-query-tailwind canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/next-react-query-tailwind/deploys/64edff6f112d470007ce1d52

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for angular-apollo-tailwind canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/angular-apollo-tailwind/deploys/64edff6f35d8b0000864005b

@honzikec honzikec self-assigned this Aug 18, 2023
@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for vue3-apollo-quasar canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/vue3-apollo-quasar/deploys/64edff6fd803500008316a7d

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for solidjs-tailwind ready!

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/solidjs-tailwind/deploys/64edff6f1ac2ba0008cdc80d
😎 Deploy Preview https://deploy-preview-1941--solidjs-tailwind.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for nuxt-pinia-tailwind canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-pinia-tailwind/deploys/64edff6faaa2430008892028

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for svelte-kit-scss canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/svelte-kit-scss/deploys/64edff6fc317770007ded5f1

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for starter-dev-backend canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev-backend/deploys/64edff6f6fbbd800086262bb

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for expo-zustand-styled-components canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/expo-zustand-styled-components/deploys/64edff70f078600007f92051

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for remix-gql-tailwind canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/remix-gql-tailwind/deploys/64edff6fff5e0a00070da9c9

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for solidstart-tanstackquery-tailwind-mod ready!

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/solidstart-tanstackquery-tailwind-mod/deploys/64edff6faf73e80008d54f06
😎 Deploy Preview https://deploy-preview-1941--solidstart-tanstackquery-tailwind-mod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for qwik-graphql-tailwind canceled.

Name Link
🔨 Latest commit 7bcdce2
🔍 Latest deploy log https://app.netlify.com/sites/qwik-graphql-tailwind/deploys/64edff6f6d1faa0008b95b22

@honzikec honzikec mentioned this pull request Aug 18, 2023
3 tasks
@honzikec honzikec requested review from Megio and removed request for lindakatcodes August 29, 2023 09:50
@Megio
Copy link
Contributor

Megio commented Aug 29, 2023

@honzikec I am not an Angular expert, but the code looks good. The only thing I found is that according to the ticket acceptance criteria, pagination should work on issues page, but it doesn't: #833

Would we create a separate ticket for this?

@honzikec
Copy link
Contributor Author

@honzikec I am not an Angular expert, but the code looks good. The only thing I found is that according to the ticket acceptance criteria, pagination should work on issues page, but it doesn't: #833

Would we create a separate ticket for this?

Good catch, @Megio! That was actually my fault, pushed a fix 🙂

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Megio Megio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@honzikec honzikec merged commit ae1a799 into main Aug 29, 2023
61 checks passed
@honzikec honzikec deleted the angular-ngrx-scss/issues branch August 29, 2023 15:58
@thisdot-bot
Copy link

Hi @honzikec. 👋

Your PR has been approved and merged. 🎉

Thank you for your continued contributions to the starter.dev GitHub showcases repo. ❤️

Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Angular - NgRx - SCSS] Issues tab should show current issues
3 participants