Org profile page #659
Org profile page #659
Conversation
hdJerry
commented
Sep 29, 2022
•
hdJerry
commented
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| <div class="q-pt-md q-mx-auto"> | ||
| <div class="row items-center" v-if="!loadingOrgProfileDetail"> | ||
| <span class="company_logo q-mr-sm rounded-borders"> | ||
| <img :src="orgProfileDetail?.avatarUrl" alt="company logo" /> |
There was a problem hiding this comment.
hide image if the a orgProfileDetail?.avatarUrl is not a valid src
| </small> | ||
| </div> | ||
| <div> | ||
| <a :href="'/' + username" class="row items-center clear-filter"> |
There was a problem hiding this comment.
move link composing logic into computed
| ); | ||
| } else if (sortByData.value?.sortby === SORT_OPTIONS.stars) { | ||
| response.sort((a, b) => | ||
| b.node.stargazerCount > a.node.stargazerCount ? 1 : -1, |
There was a problem hiding this comment.
what if equal? it can cause different result for different order and count. Handle 0 as you did above
There was a problem hiding this comment.
Not sure this is valid. We are sorting, yeah, so if ) then it will be at the end.
| ); | ||
| } else { | ||
| response.sort((a, b) => | ||
| getTime(b.node.updatedAt) - getTime(a.node.updatedAt) ? 1 : -1, |
| if ( | ||
| search !== '' && | ||
| !repo?.node.name?.toLocaleLowerCase().includes(search.toLocaleLowerCase()) | ||
| ) { |
There was a problem hiding this comment.
| if ( | |
| search !== '' && | |
| !repo?.node.name?.toLocaleLowerCase().includes(search.toLocaleLowerCase()) | |
| ) { | |
| if ( | |
| search && | |
| !repo?.node.name?.toLocaleLowerCase().includes(search.toLocaleLowerCase()) | |
| ) { |
| }); | ||
| } | ||
| }); | ||
| languages.sort((a, b) => (a.name > b.name ? 1 : -1)); |
| width: 32px; | ||
| height: 32px; |
| /> | ||
| <span | ||
| class="tab_label q-mx-sm" | ||
| :class="{ 'text-weight-bold': tab === 'packages' }" |
There was a problem hiding this comment.
move tabs values to enum. Do not harddcode them. It is hard to maintain
| export const inArray = ( | ||
| array: ArrayData[], | ||
| target: string, | ||
| ): { name: string } | undefined => { | ||
| return array.find((arr) => arr.name === target); | ||
| }; |
There was a problem hiding this comment.
| export const inArray = ( | |
| array: ArrayData[], | |
| target: string, | |
| ): { name: string } | undefined => { | |
| return array.find((arr) => arr.name === target); | |
| }; | |
| export const inArray = ( | |
| array: ArrayData[], | |
| target: string, | |
| ): ArrayData | undefined => { | |
| return array.find((arr) => arr.name === target); | |
| }; |
| if (filterText.endsWith('s')) { | ||
| if (filterText.match(new RegExp('forks', 'i'))) { | ||
| filterText = filterText.replace('s', 'ed'); | ||
| } else { | ||
| filterText = filterText.replace('s', ''); | ||
| } | ||
| } |
There was a problem hiding this comment.
what if the work contans multiple 's' letters?
AllStackDev1
requested review from
SDaian
and removed request for
SDaian and
AllStackDev1
✅ Deploy Preview for cra-rxjs-styled-components canceled.
|
✅ Deploy Preview for next-react-query-tailwind canceled.
|
✅ Deploy Preview for angular-apollo-tailwind canceled.
|
✅ Deploy Preview for starter-dev-backend canceled.
|
✅ Deploy Preview for nuxt-pinia-tailwind canceled.
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @hdJerry. 👋 Your PR has been approved and merged. 🎉 Thank you for your continued contributions to the starter.dev GitHub showcases repo. ❤️ Keep up the great work! |
