Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean up for algebras #1623

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat: clean up for algebras #1623

merged 1 commit into from
Oct 18, 2024

Conversation

thofma
Copy link
Owner

@thofma thofma commented Sep 22, 2024

No description provided.

@thofma thofma force-pushed the th/alghom branch 4 times, most recently from 0b362cd to 6323b05 Compare September 22, 2024 15:31
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 18 lines in your changes missing coverage. Please review.

Project coverage is 75.89%. Comparing base (9a1165a) to head (17230a6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/AlgAss/Ideal.jl 93.19% 10 Missing ⚠️
src/AlgAssRelOrd/Eichler.jl 0.00% 4 Missing ⚠️
src/AlgAss/Types.jl 50.00% 2 Missing ⚠️
src/AlgAss/AlgMat.jl 75.00% 1 Missing ⚠️
src/AlgAssAbsOrd/Ideal.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   75.86%   75.89%   +0.03%     
==========================================
  Files         361      361              
  Lines      113685   113719      +34     
==========================================
+ Hits        86244    86306      +62     
+ Misses      27441    27413      -28     
Files with missing lines Coverage Δ
src/AlgAss/AbsAlgAss.jl 88.20% <100.00%> (ø)
src/AlgAss/AlgGrp.jl 73.06% <100.00%> (+0.16%) ⬆️
src/AlgAss/Elem.jl 88.60% <100.00%> (+0.05%) ⬆️
src/AlgAss/Map.jl 79.61% <100.00%> (ø)
src/AlgAss/radical.jl 94.78% <100.00%> (ø)
src/AlgAssRelOrd/Ideal.jl 73.06% <100.00%> (ø)
src/AlgAss/AlgMat.jl 89.05% <75.00%> (+0.51%) ⬆️
src/AlgAssAbsOrd/Ideal.jl 77.04% <50.00%> (-0.09%) ⬇️
src/AlgAss/Types.jl 82.89% <50.00%> (-4.61%) ⬇️
src/AlgAssRelOrd/Eichler.jl 22.61% <0.00%> (ø)
... and 1 more

... and 31 files with indirect coverage changes

@thofma thofma marked this pull request as ready for review October 18, 2024 18:40
@thofma thofma enabled auto-merge (squash) October 18, 2024 20:30
@thofma thofma merged commit c2ecdc9 into master Oct 18, 2024
18 checks passed
@thofma thofma deleted the th/alghom branch October 18, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant