Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strange checkbounds method #1680

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

fingolfin
Copy link
Contributor

It seems to be unused

It seems to be unused
@fieker
Copy link
Collaborator

fieker commented Nov 11, 2024

I thin that was an attempt to support @inbounds/ boundscheck in Julia in Nemo/Hecke.
No idea how far we are in that direction

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (b085401) to head (a319dec).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1680      +/-   ##
==========================================
+ Coverage   75.95%   75.96%   +0.01%     
==========================================
  Files         361      361              
  Lines      113878   113877       -1     
==========================================
+ Hits        86498    86509      +11     
+ Misses      27380    27368      -12     
Files with missing lines Coverage Δ
src/Hecke.jl 51.28% <ø> (+0.16%) ⬆️

... and 24 files with indirect coverage changes

@thofma thofma enabled auto-merge (squash) November 11, 2024 16:25
@thofma thofma merged commit 0299a8d into thofma:master Nov 11, 2024
17 checks passed
@fingolfin fingolfin deleted the mh/checkbounds branch November 11, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants