Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream SONiC MPLS changes to libnl3 #284

Closed
wants to merge 1 commit into from
Closed

Conversation

qbdwlr
Copy link
Contributor

@qbdwlr qbdwlr commented May 25, 2021

libnl 3.5.0 is currently used by the open-source project SONiC (https://github.com/Azure/sonic-buildimage.git)
Several patches are made to the SONiC version of libnl to better support MPLS.
The purpose of this PR is to upstream these SONiC MPLS changes to libnl for general usage.

  1. New accessors for setting/getting ENCAP_MPLS attributes.
  2. Removed incorrect usage of nl_addr_valid() from NEWDST and ENCAP_MPLS DST processing.

@qbdwlr
Copy link
Contributor Author

qbdwlr commented Nov 6, 2021

@thom311 @bengal Is there any chance that this PR will be reviewed/approved/merged? As I stated in the PR summary, these changes were deemed necessary to fully support MPLS in the Azure SONiC project where the changes have been merged as a patch to libnl 3.5.0. The preference would be to have the changes be native to libnl and discard the patch.

thom311 added a commit that referenced this pull request Mar 4, 2022
Upstream SONiC MPLS changes to libnl3.

#284
@thom311
Copy link
Owner

thom311 commented Mar 4, 2022

merged to master.

With some changes, in particular writing a commit message and splitting patches.

thank you!!

@thom311 thom311 closed this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants