Propose alternative for CSS imports in Vite projects #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tom,
I've been trying to use your library in a Bolt Svelte plugin and couldn't find a way out of this error when importing the CSS as you documented:
It seems that the way they've set up Vite, it does not load CSS in external dependencies, and I don't know Svelte well enough to figure out how to address this.
By adding a subpath export to your package, I can however let Vite import and process your global CSS with no effort. If you would please consider merging this PR, it would make my life considerably easier as I'm stuck having to duplicate your CSS file at the moment 😅
Thanks,