-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap for v1.0 #8
Comments
I have a question. How many browsers I can spawn in parallel for processor core? Lets Say my server has processor with 4 cores. How many browsers I can spawn in one time for my tests to pass? |
Next time, please open a separate issue if it has nothing to do with this issue. Regarding your question: It depends on your use case. For simple DOM handling I was able to run ~10 worker on my machine (i5 quad core). Just give it a try with the option (monitor: true) and see how your machine is handling the tasks. |
|
Unfortunately, the current implementation of custom concurrency doesn't address the case when you need to provide custom puppeteer parameters to @thomasdondorf , what do you think about this? |
I'm currently thinking about completely reworking the concurrency implementations. Then there would be no more "WorkerInstance" and "JobInstance". Just one function that is called when a page is needed. Then the concurrency implementation would have 100% flexibility when a puppeteer instance is started and when one is reused. Expect some code changes in the next two weeks ;) |
Cool, glad to hear that. Feel free to ping me if you need any help) |
+1 for Docker container support. |
Is there a way to connect the puppeteer-cluster to a remote instance of chromium? (“connect” instead of “launch”) |
Hello - just wanted to get a feel for how active this project is. I see puppeteer cluster as being useful for several projects I'd like to work on. However, I'm hesitant to use it if development will be abandoned. Is development still happening? Thanks! |
I use k6 benchmarks in my CI tests for soketi, making sure all releases are passing benchmarks in most of the cases. Would it be a great idea to set it up for you for page rendering testing? |
I'm thinking about what kind of functionality this library should provide before it should be released as v1. I might edit the list in the future:
My goals:
ImproveNot a goal for 1.0 anymoresameDomainDelay
andskipDuplicateUrls
. Detection of domains should use TLD.js for example. Documentation should be better. And there should be a way to provide the URL without using data or { url: ... }CONCURRENCY_BROWSER
the default as it is more robust?Cluster.queue
for example)cluster.execute
function which executes the jobwith higher priority (does not queue it at the end)and returns a Promise which is resolved when the job is finished. Might also solve this confusion: whyawait
? #10 (comment)SandboxOffer a way to run code from users in a sandbox, maybe even Docker? => This can now be implemented via custom concurrency implementations (although there are now custom implementations right now)Maybe:
concurrency
should beconcurrencyType
maxConcurrency
maybemaxWorkers
?Not planned (for now):
Roadmap for v1.0 #8 (comment) Mixed concurrency modelsThe text was updated successfully, but these errors were encountered: