Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch direction attribute #298

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Patch direction attribute #298

wants to merge 2 commits into from

Conversation

RoboMagus
Copy link

Workaround the forced direction on ha-slider. Fixes #297.

@RoboMagus
Copy link
Author

RoboMagus commented Apr 7, 2024 •
edited
Loading

Hold off on merging it for a bit. Just noticed that reloading a tab apparently causes the direction to revert again. So I'll have to look into that...

Fixed by moving the attribute change into connectedCallback

@RoboMagus RoboMagus marked this pull request as draft April 7, 2024 20:49
@RoboMagus RoboMagus marked this pull request as ready for review April 8, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rtl direction appears to be broken
1 participant
@RoboMagus