Skip to content

Commit

Permalink
Fix test issue with the new format
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Poignant <[email protected]>
  • Loading branch information
thomaspoignant committed Apr 28, 2023
1 parent b6122ce commit 4c2cd23
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 12 deletions.
20 changes: 11 additions & 9 deletions cmd/relayproxy/service/gofeatureflag_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,19 @@ func Test_initRetriever(t *testing.T) {
name: "Convert Gitlab Retriever",
wantErr: assert.NoError,
conf: &config.RetrieverConf{
Kind: "gitlab",
URL: "http://localhost",
Path: "flag-config.yaml",
Timeout: 20,
Kind: "gitlab",
BaseURL: "http://localhost",
Path: "flag-config.yaml",
RepositorySlug: "thomaspoignant/go-feature-flag",
Timeout: 20,
},
want: &gitlabretriever.Retriever{
URL: "http://localhost",
Branch: "main",
FilePath: "flag-config.yaml",
GitlabToken: "",
Timeout: 20 * time.Millisecond,
BaseURL: "http://localhost",
Branch: "main",
FilePath: "flag-config.yaml",
RepositorySlug: "thomaspoignant/go-feature-flag",
GitlabToken: "",
Timeout: 20 * time.Millisecond,
},
},
{
Expand Down
7 changes: 4 additions & 3 deletions config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,10 @@ func TestConfig_GetRetrievers(t *testing.T) {
fields: fields{
PollingInterval: 3 * time.Second,
Retriever: &gitlabretriever.Retriever{
URL: "https://gitlab.com/ruairi2/go-feature-flags-config",
FilePath: "flag-config.yaml",
GitlabToken: "XXX",
BaseURL: "https://gitlab.com/",
RepositorySlug: "ruairi2/go-feature-flags-config",
FilePath: "flag-config.yaml",
GitlabToken: "XXX",
},
},
want: "*gitlabretriever.Retriever",
Expand Down

0 comments on commit 4c2cd23

Please sign in to comment.