Skip to content

Commit

Permalink
remove Print
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Poignant <[email protected]>
  • Loading branch information
thomaspoignant committed Oct 12, 2022
1 parent dc229d4 commit e4d8f4f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
3 changes: 0 additions & 3 deletions cmd/migrationcli/converter/converter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,6 @@ func TestFlagConverter_Migrate(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
got, err := tt.converter.Migrate()
tt.wantErr(t, err, fmt.Sprintf("Migrate(): %s", err))

fmt.Println(string(got))

if tt.wantFileLocation != "" {
want, err := os.ReadFile(tt.wantFileLocation)
assert.NoError(t, err)
Expand Down
3 changes: 1 addition & 2 deletions exporter/webhookexporter/exporter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package webhookexporter

import (
"context"
"fmt"
"log"
"os"
"testing"
Expand Down Expand Up @@ -166,7 +165,7 @@ func TestWebhook_Export(t *testing.T) {
assert.NoError(t, err)
if tt.expected.bodyFilePath != "" {
c, err := os.ReadFile(tt.expected.bodyFilePath)
fmt.Println(err)
assert.NoError(t, err)
assert.JSONEq(t, string(c), tt.fields.httpClient.Body)
}

Expand Down
6 changes: 1 addition & 5 deletions notifier/slacknotifier/notifier.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,7 @@ func convertUpdatedFlagsToSlackMessage(diffCache notifier.DiffCache) []attachmen
Fields: []Field{},
}

changelog, err := diff.Diff(value.Before, value.After, diff.AllowTypeMismatch(true))
if err != nil {
fmt.Println(err)
}

changelog, _ := diff.Diff(value.Before, value.After, diff.AllowTypeMismatch(true))
for _, change := range changelog {
if change.Type == "update" {
value := fmt.Sprintf("%s => %s", render.Render(change.From), render.Render(change.To))
Expand Down

0 comments on commit e4d8f4f

Please sign in to comment.