Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all tests using v0.x.x flag format #2401

Closed
1 of 2 tasks
thomaspoignant opened this issue Sep 20, 2024 · 2 comments · Fixed by #2477
Closed
1 of 2 tasks

Change all tests using v0.x.x flag format #2401

thomaspoignant opened this issue Sep 20, 2024 · 2 comments · Fixed by #2477
Assignees
Labels
📍 Assigned change This is a change in the code that should not affect the users p2 Medium priority stop v0 support Tag to group everything about the un-support of v0.x.x flag format

Comments

@thomaspoignant
Copy link
Owner

thomaspoignant commented Sep 20, 2024

Warning

As mention in the issue #2398 we have decided to drop the support of the v0.x.x flag format.
Before creating a pull request for that, please check in the main issue if is the right moment to do it.

Some tests are still using the v0 flag format and are not migrated to the v1 format.
To be able to drop completely the v0 format we need to be sure that all the tests are using the v1 format.

What should we do?

  • Update all tests that are still using the v0 format to use the v1 format
  • Remove tests used for format compatibility checks (ex: check that v0 and v1 are affecting users to the same variant)
@thomaspoignant thomaspoignant added p2 Medium priority change This is a change in the code that should not affect the users stop v0 support Tag to group everything about the un-support of v0.x.x flag format labels Sep 20, 2024
@thomaspoignant
Copy link
Owner Author

/assign-me

Copy link
Contributor

github-actions bot commented Oct 7, 2024

👋 Hey @thomaspoignant, thanks for your interest in this issue! 🎉

⚠ Note that this issue will become unassigned if it isn't closed within 10 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned change This is a change in the code that should not affect the users p2 Medium priority stop v0 support Tag to group everything about the un-support of v0.x.x flag format
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant