Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove usage of flag v0 in test #2477

Merged
merged 3 commits into from
Oct 7, 2024
Merged

feat: Remove usage of flag v0 in test #2477

merged 3 commits into from
Oct 7, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

Remove all call to flag v0 format in tests.

Closes issue(s)

Resolve #2401

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit dd4b3ca
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6703e2972ec47a0008172b57
😎 Deploy Preview https://deploy-preview-2477--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (4683e18) to head (dd4b3ca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
model/dto/converter_v0.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2477      +/-   ##
==========================================
- Coverage   85.56%   79.84%   -5.72%     
==========================================
  Files         103      103              
  Lines        3816     3816              
==========================================
- Hits         3265     3047     -218     
- Misses        425      643     +218     
  Partials      126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 7, 2024

@thomaspoignant thomaspoignant merged commit afb2bef into main Oct 7, 2024
20 of 22 checks passed
@thomaspoignant thomaspoignant deleted the chore-2401 branch October 7, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change all tests using v0.x.x flag format
1 participant