-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature) Amazon Kinesis Exporter #2557
Comments
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedhttps://www.linkedin.com/in/batiyiv/ How I plan on tackling this issueI'll check structure of Kafka explorer, and recreate similar. Will create a Kinesis stream for test, manually test against it. Maybe will use localstack to organise testing. |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedI am a software developer with experience in building frontend application which are web and mobile compactable. Experienced in some of the tech stack used like typescript JS python C reactnative But am open to learning with the project How I plan on tackling this issueA psuedo approach to solving the above task would be : Step 1: Analyze the Existing Structure Step 2: Design the Kinesis Exporter Step 3: Implement the Exporter Interface Step 4: Set Up AWS Credentials Step 5: Create a Kinesis Client Step 6: Implement the Export Method Step 7: Handle Errors and Logging Step 8: Test the Implementation |
@thomaspoignant
|
@baitcode How super nice to see that you progressed that fast.
Since we are not in bulk mode here (because of the answer from the previous question) I doubt we will reach the 1Mb event size, so your approach is ok for me. |
Kinesis exporter implementation with tests
@thomaspoignant Is order of the events is a stream important? I'm thinking if I should distribute events into different Kinesis shards by default or just use a single hardcoded shard. I'll do the single shard for now, and let's fix it on review phase if you feel like it's a wrong approach. |
@thomaspoignant I'll do another round of review later today, but would love if you did as well on your side. I don't expect any major changes except for documentation, as I tested documentation poorly. |
Requirements
GO Feature Flag is supporting different solution to export the flag evaluation to your existing system.
The list of existing exporter destination are available here.
GO Feature Flag is already supporting some queue systems (SQS, SNS, Kafka, GCP PubSub ...), but adding the compatibility to AWS Kinesis would be a very nice addition for the users using it in their AWS instance.
A good example on how to implement this exporter is to look at the Kafka exporter https://github.com/thomaspoignant/go-feature-flag/pull/1426/files.
The text was updated successfully, but these errors were encountered: