-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add event source field #1105
Feature/add event source field #1105
Conversation
hey, @thomaspoignant, please have a look whenever you have some time =) I failed to see my changes to the docs locally 🤔 , also I'm taking a look at the failed pipeline steps |
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
…detti/go-feature-flag into feature/add-event-source-field
Codecov Report
@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
+ Coverage 88.52% 88.54% +0.01%
==========================================
Files 69 69
Lines 3155 3159 +4
==========================================
+ Hits 2793 2797 +4
Misses 292 292
Partials 70 70
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I haven’t check the PR yet but if you want to have swagger CI to pass you will have to generate the new swagger schema. To do this please run |
…detti/go-feature-flag into feature/add-event-source-field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @andrebenedetti this is a great addition to GO Feature Flag.
I've only 1 small feedback to be sure we are not overriding the field if it is already set in the event. We should also probably add a test for this use-case.
@thomaspoignant good points I'll make those changes later today. Thanks for reviewing |
Co-authored-by: Thomas Poignant <[email protected]>
Thanks for the awesome work on this PR. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🎆 thanks for the support |
Oh yes, let me know. In any case I would be happy to get your feedback about the repo. |
Description
Added
Source
field on FeatureEventSource is set to "PROVIDER_CACHE" for events received through the CollectEvalData endpoint. Otherwise, it is set to "SERVER"
Changes include
Closes issue(s)
Resolve #978
Checklist
README.md
and/website/docs
)