Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusion in RetrieverConf's struct tag declaration #1266

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

imhuytq
Copy link
Contributor

@imhuytq imhuytq commented Nov 16, 2023

Description

In the struct tag declaration of RetrieverConf's Object field, which is being mistaken for bucket, the correct value should be object.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #1265

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 3599b66
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6555b3d91842580007ca6888

Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f046653) 88.67% compared to head (3599b66) 88.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1266   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files          70       70           
  Lines        3275     3275           
=======================================
  Hits         2904     2904           
  Misses        301      301           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @imhuytq thanks a lot for this PR, this is a good catch.
You are right we had an issue on this for environment variable.

I will release a new version Today with your fix.

@thomaspoignant thomaspoignant merged commit 9f62950 into thomaspoignant:main Nov 16, 2023
23 checks passed
@thomaspoignant
Copy link
Owner

thomaspoignant commented Nov 16, 2023

@imhuytq the version v1.18.2 fixing the issue is released.

@imhuytq
Copy link
Contributor Author

imhuytq commented Nov 16, 2023

@thomaspoignant thank bro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) The configuration for Google Cloud Storage Retriever is incorrect when read from environment variables
2 participants