-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of evaluation context enrichment #1285
Conversation
Signed-off-by: Thomas Poignant <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
+ Coverage 88.67% 88.68% +0.01%
==========================================
Files 70 71 +1
Lines 3275 3287 +12
==========================================
+ Hits 2904 2915 +11
- Misses 301 302 +1
Partials 70 70 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
…elay proxy Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the new evaluation context should meet the requirements outlined in #1270
Looking forward to trying it out!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
The common evaluation context is a new mechanism that enriches all the evaluation contexts with a common context of the execution server.
This is particularly useful when you support different environment variables, or if you want to target a specific server.
To use it, you can configure the field
EvaluationContextEnrichment
(map[string]interface{}
), so you can add everything you want to enrich the request.EvaluationContextEnrichment
and in theEvaluationContext
, theEvaluationContextEnrichment
will override what was set in theEvaluationContext
.Example
If you configure your
EvaluationContextEnrichment
like this:And you evaluation your flag with this context:
Your context will be merged and you will be able to create rules about all those fields:
Changes include
Closes issue(s)
Resolve #1270
Checklist
README.md
and/website/docs
)