Async call to the exporter in non-bulk mode #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
fix-non-blocking-data-exporter
branch
from
b7d1b55
to
4765257
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
=======================================
Coverage 88.35% 88.36%
=======================================
Files 75 75
Lines 3496 3498 +2
=======================================
+ Hits 3089 3091 +2
Misses 332 332
Partials 75 75 ☔ View full report in Codecov by Sentry. |
thomaspoignant
added a commit
that referenced
this pull request
Sep 5, 2024
* async call to exporter Signed-off-by: Thomas Poignant <[email protected]> * Fix test to be comptible with async call Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When in a non-bulk mode the call to the exporter was synchronous, which can cause delay in the flag evaluation.
This PR ensure we use a goroutine to call the exporter.
Checklist