relayproxy: Add the possibility to have 2 differents port for metrics and business #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
==========================================
- Coverage 88.36% 87.67% -0.70%
==========================================
Files 75 77 +2
Lines 3498 3626 +128
==========================================
+ Hits 3091 3179 +88
- Misses 332 364 +32
- Partials 75 83 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Poignant <[email protected]>
|
thomaspoignant
added a commit
that referenced
this pull request
Feb 2, 2024
* Revert "relayproxy: Add the possibility to have 2 differents port for metrics and business (#1502)" This reverts commit a313516. * Fixing some issue in the multiport setup that broke the integration tests Signed-off-by: Thomas Poignant <[email protected]> * Fix close Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
thomaspoignant
added a commit
that referenced
this pull request
Sep 5, 2024
… and business (#1502) * Add the possibility to have 2 differents port for metrics and the rest Signed-off-by: Thomas Poignant <[email protected]> * Add documentation Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
added a commit
that referenced
this pull request
Sep 5, 2024
* Revert "relayproxy: Add the possibility to have 2 differents port for metrics and business (#1502)" This reverts commit a313516. * Fixing some issue in the multiport setup that broke the integration tests Signed-off-by: Thomas Poignant <[email protected]> * Fix close Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following issue #1499, this PR introduces the possibility of running
metricsandhealth checkson different ports.This is a requirement for some companies that prefer not to mix the 2 things simultaneously.
In this implementation, we are starting another instance of
echofor the metrics if the parammonitoringPortis set in the configuration.If this option is not set the monitoring will continue to work on the same port of the business logic.
Changes include
Closes issue(s)
Resolve #1499
Checklist
README.mdand/website/docs)