-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relayproxy: Add the possibility to have 2 differents port for metrics and business #1502
Conversation
Signed-off-by: Thomas Poignant <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
==========================================
- Coverage 88.36% 87.67% -0.70%
==========================================
Files 75 77 +2
Lines 3498 3626 +128
==========================================
+ Hits 3091 3179 +88
- Misses 332 364 +32
- Partials 75 83 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Poignant <[email protected]>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
* Revert "relayproxy: Add the possibility to have 2 differents port for metrics and business (#1502)" This reverts commit a313516. * Fixing some issue in the multiport setup that broke the integration tests Signed-off-by: Thomas Poignant <[email protected]> * Fix close Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
… and business (#1502) * Add the possibility to have 2 differents port for metrics and the rest Signed-off-by: Thomas Poignant <[email protected]> * Add documentation Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]>
* Revert "relayproxy: Add the possibility to have 2 differents port for metrics and business (#1502)" This reverts commit a313516. * Fixing some issue in the multiport setup that broke the integration tests Signed-off-by: Thomas Poignant <[email protected]> * Fix close Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Description
Following issue #1499, this PR introduces the possibility of running
metrics
andhealth checks
on different ports.This is a requirement for some companies that prefer not to mix the 2 things simultaneously.
In this implementation, we are starting another instance of
echo
for the metrics if the parammonitoringPort
is set in the configuration.If this option is not set the monitoring will continue to work on the same port of the business logic.
Changes include
Closes issue(s)
Resolve #1499
Checklist
README.md
and/website/docs
)