fix(OFREP): keep targetingKey in the custom data to continue to have rules enabled #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Signed-off-by: Thomas Poignant <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1905 +/- ##
==========================================
- Coverage 86.80% 86.80% -0.01%
==========================================
Files 95 95
Lines 3433 3432 -1
==========================================
- Hits 2980 2979 -1
Misses 349 349
Partials 104 104 ☔ View full report in Codecov by Sentry. |
|
thomaspoignant
added a commit
that referenced
this pull request
Sep 5, 2024
…rules enabled (#1905) * keep targetingKey in the custom data to continue to have rules enabled Signed-off-by: Thomas Poignant <[email protected]> * Fix tests Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling the evaluation for OFREP we had an issue writing rules using
targetingKeyas key because it was removed from the evaluation context (in favor ofkey).In this PR we stop removing
targetingKeyto be able to use both key names.Closes issue(s)
Resolve #1898
Checklist
README.mdand/website/docs)