Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kotlin provider full support #2114

Merged
merged 13 commits into from
Jul 22, 2024
Merged

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Jul 19, 2024

Description

This PR contains a working version of the Android provider for GO Feature Flag.
With this version we can remove the experimental badge for the provider.

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 01959bc
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/669a808b81915f0008cc8a15

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit d568fa8
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/669eb67b8ffecf0008ff50dd
😎 Deploy Preview https://deploy-preview-2114--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (fd9a95a) to head (d568fa8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2114   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files          98       98           
  Lines        3661     3661           
=======================================
  Hits         3161     3161           
  Misses        382      382           
  Partials      118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@thomaspoignant thomaspoignant changed the title Release kotlin provider feat: kotlin provider in mature stage Jul 22, 2024
@thomaspoignant thomaspoignant changed the title feat: kotlin provider in mature stage feat: kotlin provider full support Jul 22, 2024
@thomaspoignant thomaspoignant marked this pull request as ready for review July 22, 2024 19:49
@thomaspoignant thomaspoignant merged commit 7a1c0a2 into main Jul 22, 2024
22 of 25 checks passed
@thomaspoignant thomaspoignant deleted the release-kotlin-provider branch July 22, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant