Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add BucketingKey to DTO converter functions #2377

Merged

Conversation

ricardobeat
Copy link
Contributor

Description

Was pulling my hair trying to figure out why the new bucketing didn't work on the server. Turns out we forgot to add it to the converters, so it gets lost in the cache initialization phase.

Tests don't cover this, should they?

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 345ca06
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/66ecd1812f10a90008fbe815

Copy link

sonarcloud bot commented Sep 20, 2024

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (7e20e6a) to head (345ca06).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2377   +/-   ##
=======================================
  Coverage   86.10%   86.11%           
=======================================
  Files         102      102           
  Lines        3778     3780    +2     
=======================================
+ Hits         3253     3255    +2     
  Misses        400      400           
  Partials      125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant
Copy link
Owner

There is clearly a missing test, I will add it before merging this PR and releasing a fix version.

@thomaspoignant thomaspoignant changed the title add BucketingKey to DTO converter functions fix: add BucketingKey to DTO converter functions Sep 20, 2024
@thomaspoignant thomaspoignant merged commit 3d42409 into thomaspoignant:main Sep 20, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants