Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle errors in flagState conversion #2455

Merged
merged 4 commits into from
Oct 4, 2024
Merged

fix: Handle errors in flagState conversion #2455

merged 4 commits into from
Oct 4, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

When not setting a targetingKey and calling allFlagState we had an error saying that the TYPE_MISMATCH which was not explicit enough to understand the issue.

Not we are returning TARGETING_KEY_MISSING which is more explicit.

Closes issue(s)

Resolve #2453

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 092d3e5
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6700188bcee72200085452bd

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (b5144e3) to head (092d3e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
- Coverage   86.02%   85.56%   -0.47%     
==========================================
  Files         102      103       +1     
  Lines        3801     3816      +15     
==========================================
- Hits         3270     3265       -5     
- Misses        405      425      +20     
  Partials      126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 4, 2024

@thomaspoignant thomaspoignant merged commit a680901 into main Oct 4, 2024
21 of 22 checks passed
@thomaspoignant thomaspoignant deleted the fix-2453 branch October 4, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(question) Getting a Type MiSMATCH Error
1 participant