-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes configmaps #247
Kubernetes configmaps #247
Conversation
FTR: I have to test it later. Right now I don't have access to a Kubernetes cluster. |
Hello @mschoenlaub, let me know when you are happy with your pull request and I will have a look. |
@thomaspoignant Finally I could test it against GKE. What we have as of now, is a solution to store the config file under a specific key in a config map. E.g. once you did
a config like this:
will do the right thing. |
@mschoenlaub thanks a lot for your contribution this is awesome. It could be great to have an example in |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@mschoenlaub I have tested your solution and it is all fine for me. I've also edit some stuff in the documentation. Thanks a lot for your contribution this is awesome 🙏 |
great progress @mschoenlaub. Awesome that you made this happen! |
@thomaspoignant Sorry for getting back so late. Got caught up in life somewhow :D Though I am gonna have one nitpick for the example: "// Init ffclient with an http retriever." seems to be a copy/paste error ;-) Thanks for getting that in so fast. |
Thanks for the copy/paste error I'll fix this. |
Description
This PR adds initial support for JSON and YAML encoded flag data in a Kubernetes ConfigMap.
Changes include
Closes issue(s)
Resolve #213
Checklist