Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Coverage increase #2478

Merged
merged 8 commits into from
Oct 7, 2024
Merged

chore: Coverage increase #2478

merged 8 commits into from
Oct 7, 2024

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Oct 7, 2024

Description

Adding more tests to improve coverage

Checklist

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 9042ec4
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6704211a9e61e000093fb8ce

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.74%. Comparing base (afb2bef) to head (9042ec4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/gcstorageexporter/exporter.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2478      +/-   ##
==========================================
+ Coverage   79.84%   85.74%   +5.89%     
==========================================
  Files         103      102       -1     
  Lines        3816     3606     -210     
==========================================
+ Hits         3047     3092      +45     
+ Misses        643      390     -253     
+ Partials      126      124       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 7, 2024

@thomaspoignant thomaspoignant marked this pull request as ready for review October 7, 2024 18:45
@thomaspoignant thomaspoignant merged commit 1bae773 into main Oct 7, 2024
21 of 22 checks passed
@thomaspoignant thomaspoignant deleted the coverage-increase branch October 7, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant