Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding flag hashes in /v1/flag/change API #2492

Merged
merged 3 commits into from
Oct 11, 2024
Merged

feat: Adding flag hashes in /v1/flag/change API #2492

merged 3 commits into from
Oct 11, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

In this PR we start returning an array of hashes (as uint32) for each flag.
It will allow server providers to store those hashes and compare them when a change is detected to be able to emit a flag change event with the information of which flag has changed.

See #2404 for more details.

Closes issue(s)

Resolve #2404

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 3250f3f
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6706efd52928220008a784d0

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit fb8f94a
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6708fab5c1a5d2000872dcd4

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (fde9fff) to head (fb8f94a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2492      +/-   ##
==========================================
+ Coverage   86.18%   86.20%   +0.01%     
==========================================
  Files         100      100              
  Lines        3526     3530       +4     
==========================================
+ Hits         3039     3043       +4     
  Misses        360      360              
  Partials      127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 11, 2024

@kodiakhq kodiakhq bot merged commit 1087c3a into main Oct 11, 2024
22 checks passed
@kodiakhq kodiakhq bot deleted the feat-2404 branch October 11, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Send flag hashes on /v1/flag/change endpoint
1 participant