Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove support for v0 format #2496

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: Remove support for v0 format #2496

wants to merge 4 commits into from

Conversation

thomaspoignant
Copy link
Owner

Description

This PR is removing the v0 format support from GO Feature Flag.

Warning

This PR should be merged when releasing a version that remove support for v0 format.
We should wait at least until v1.40.0 before releasing it.

Closes issue(s)

Resolve #2403 #2398

Checklist

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit c60b001
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6707e659381b320008da350e

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 71b946e
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/67091b40c44a0000093d7301

@thomaspoignant thomaspoignant added the on-hold If you're PR is ready but needs to wait a bit before merging it label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (ed39a6e) to head (71b946e).

Files with missing lines Patch % Lines
cmd/editor/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
+ Coverage   86.48%   86.56%   +0.08%     
==========================================
  Files         100      100              
  Lines        3544     3536       -8     
==========================================
- Hits         3065     3061       -4     
+ Misses        352      349       -3     
+ Partials      127      126       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold If you're PR is ready but needs to wait a bit before merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor DTO layer to support v1 flag format only
1 participant