-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CI - The assign/unassign GitHub Action is not working #2529
fix: CI - The assign/unassign GitHub Action is not working #2529
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
==========================================
+ Coverage 85.79% 85.84% +0.05%
==========================================
Files 100 100
Lines 3554 3554
==========================================
+ Hits 3049 3051 +2
+ Misses 379 378 -1
+ Partials 126 125 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
Let's hope that it will work better than the GH action.
Quality Gate passedIssues Measures |
Description
Problem:
The
takanome-dev/assign-issue-action
(currently used) only works properly when assigning issues, not when unassigning.The way it was resolved:
Use custom script to check comments containing
/assign-me
to specify assignees, add necessary labels and commentsUse
actions/stale@v9
to check for stale issues when specified conditions are metUse custom script to unassign and delete specific labels
How to test the change:
Change workflow schedule (
cron
), number of days before being marked as stale (env.DAYS_UNTIL_STALE
) inunassign-issue.yml
, and checkNote:
In my previous PR, this line was not covered so I added a test case for it.
Closes issue(s)
Resolve #2313
Checklist
README.md
and/website/docs
)