Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI - The assign/unassign GitHub Action is not working #2529

Merged

Conversation

hoangnv-bkhn
Copy link
Contributor

@hoangnv-bkhn hoangnv-bkhn commented Oct 14, 2024

Description

  • Problem:
    The takanome-dev/assign-issue-action (currently used) only works properly when assigning issues, not when unassigning.

  • The way it was resolved:

    • With assign assignees:
      Use custom script to check comments containing /assign-me to specify assignees, add necessary labels and comments
    • With unassign assignees
      Use actions/stale@v9 to check for stale issues when specified conditions are met
      Use custom script to unassign and delete specific labels
  • How to test the change:
    Change workflow schedule (cron), number of days before being marked as stale (env.DAYS_UNTIL_STALE) in unassign-issue.yml, and check

  • Note:
    In my previous PR, this line was not covered so I added a test case for it.

Closes issue(s)

Resolve #2313

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit 830d56f
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/670e3763c5cf600008963a4a
😎 Deploy Preview https://deploy-preview-2529--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (7333bfe) to head (830d56f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2529      +/-   ##
==========================================
+ Coverage   85.79%   85.84%   +0.05%     
==========================================
  Files         100      100              
  Lines        3554     3554              
==========================================
+ Hits         3049     3051       +2     
+ Misses        379      378       -1     
+ Partials      126      125       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.
Let's hope that it will work better than the GH action.

Copy link

sonarcloud bot commented Oct 15, 2024

@thomaspoignant thomaspoignant merged commit 5477b6e into thomaspoignant:main Oct 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) CI: The assign/unassign GitHub Action is not working
2 participants